KeyType.EC_EDWARDS in test_sign_eddsa #143
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The KeyType should be EC_EDWARDS for Ed25519 Fixes: BotanECDSA.cpp(301): ECDSA key generation failed i.e. SoftHSM goes into BotanECDSA.cpp instead of BotanEDDSA.cpp where 1.3.101.112 is handled
|
+1, and this addresses a test failure on Debian as well. One semi-related note is that the comment right below this line says to use "Ed25519" once wbond/asn1crypto#134 is merged, and that has happened already: this is commit wbond/asn1crypto@07b6305 included in asn1crypto 1.5.0. While at it, it may be worth to just bump the dependency and replace "1.3.101.112" by "ed25519". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The KeyType should be EC_EDWARDS for Ed25519
Fixes:
i.e. SoftHSM goes into
BotanECDSA.cppinstead ofBotanEDDSA.cppwhere 1.3.101.112 is handled